Repository navigation
fix(browser): Keep the current origin for // paths in url.full - #26165
Merged
Merged
Conversation
… getAbsoluteUrl Router integrations set `url.full` with `getAbsoluteUrl`, which parsed a path like `//foo/bar` as a protocol-relative URL and recorded `foo` as the host. Treat such a path as a path on the current origin instead. The Next.js app router keeps the protocol-relative meaning for `router.push()` targets, since Next.js navigates to that host. Fixes #26157 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit eac9ab2. Configure here.
Contributor
size-limit report 📦Compared: b77997a (PR test merge using develop at 4c9a4eb) Against: 4c9a4eb (develop) · base run #65205 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 24 successful. See the run.
Successful checks
|
chargome
marked this pull request as ready for review
November 6, 2026 10:55
chargome
requested review from
a team,
andreiborza,
logaretm,
msonnb,
nicohrubec and
s1gr1d
and removed request for
a team,
msonnb and
s1gr1d
November 6, 2026 10:55
andreiborza
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Router integrations set
url.fullwithgetAbsoluteUrl, which resolved a path like//foo/baras a protocol-relative URL, so the first path segment became the host (https://foo/bar).getAbsoluteUrlnow treats a leading//as a path on the current origin, the same way #21645 fixed//request paths in core. This fixes every router integration that passes a pathname to the helper.The Next.js app router is the one exception: Next.js treats
router.push('//host/x')as an external URL and navigates to that host, so the app router instrumentation keeps the protocol-relative meaning there. With a basePath, Next.js makes it a local path, and the SDK does the same.Closes #26157